fix(sql): show bridge badge for Iceberg-tiered topics before sync#2531
Merged
Conversation
…-1330] The SQL editor's "Bridge query" badge was gated on the presence of an Iceberg lag metric series rather than on whether the queried topic is actually Iceberg-tiered. A freshly-tiered topic that hasn't started translating yet emits no `iceberg_topic_translation_lag` / `iceberg_topic_commit_lag` series, so `bridge` resolved to undefined and the query — every row served from the topic tail — looked like a plain query. Classify bridge-ness from the authoritative `redpanda.iceberg.mode` config (via useTopicIcebergQuery, already used by the catalog tree), independent of lag-metric availability. Lag values default to 0 when their series is absent; the lag timeline stays hidden until real lag appears, but the badge now shows for any tiered topic.
Contributor
🚨 Registry drift detectedApp:
Components needing attention
Refresh command: bunx shadcn@latest add @redpanda/badge @redpanda/button @redpanda/resizable --overwriteGenerated by lookout audit-changes. |
malinskibeniamin
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The SQL editor's Bridge query badge now appears for any Iceberg-tiered topic, including ones that haven't synced to Iceberg yet.
Why
The badge was gated on the presence of an Iceberg lag metric, not on whether the topic is actually Iceberg-tiered:
A freshly-tiered topic that hasn't started translating yet emits no
iceberg_topic_translation_lag/iceberg_topic_commit_lagseries, sobridgeresolved toundefinedand the query — with every row served from the topic tail — was misclassified as a plain query and showed no badge. This is exactly the case where the bridge is doing the most work.Fix
Decouple bridge classification from lag display:
redpanda.iceberg.modeconfig viauseTopicIcebergQuery(already used by the catalog tree), independent of lag-metric availability.0when their series is absent; the lag timeline stays hidden until real lag appears (unchangedtotalLag === 0guard), but the badge now shows for any tiered topic.Testing
tsgo --noEmitcleansql.test.tsx)